Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

move depreciation notice to the ingress path #6031

Merged
merged 1 commit into from
Jan 16, 2025
Merged

move depreciation notice to the ingress path #6031

merged 1 commit into from
Jan 16, 2025

Conversation

cfitzw
Copy link
Contributor

@cfitzw cfitzw commented Jan 14, 2025

Move depreciation notice from ingress.paths to ingress.path.

@gansheer
Copy link
Contributor

LGTM 👍 . You can run make generate to see if the doc is what you expect to see.

squakez
squakez approved these changes Jan 15, 2025
View reviewed changes
Copy link
Contributor

@squakez squakez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

make generate is required as well to change the api and docs accordingly. Thanks!

@squakez
Copy link
Contributor

squakez commented Jan 16, 2025

Merging this, the code generation should happen automatically at night time as well.

@squakez squakez merged commit 27d8eb0 into apache:main Jan 16, 2025
10 checks passed
@cfitzw
Copy link
Contributor Author

cfitzw commented Jan 16, 2025

Closes #6028.

@cfitzw cfitzw deleted the fix-depreciation-location-on-ingress-path branch January 16, 2025 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@squakez squakez squakez approved these changes

@gansheer gansheer gansheer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cfitzw @gansheer @squakez