[CALCITE-2115] Remove not generated mongo doc, and remove useless test #4228
+7
−56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tuichenchuxin
force-pushed
the
main
branch
2 times, most recently
from
198f04c to
548c504
Compare
tuichenchuxin
changed the title
|
A very important question is, what version of MongoDB is Calcite based on? Do we need to explain it? |
Thank you for review. |
NobiGo
reviewed
Mar 7, 2025
| @@ -284,37 +284,6 @@ private CalciteAssert.AssertThat assertModel(URL url) { | |||
| "CITY=LAWTON; LONGITUDE=null; LATITUDE=null; POP=45542; STATE=OK; ID=73505"); | |||
| } | |||
|
|
|||
| @Disabled("broken; [CALCITE-2115] is logged to fix it") | |||
There was a problem hiding this comment.
I don't understand why we directly deleted the test cases that couldn't run. A better approach should be to make them run as we want.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/CALCITE-2115