Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: minimize dependence to avoid depends on protoc_lib #2881

Merged
merged 1 commit into from
Jan 23, 2025

Conversation

tongke6
Copy link
Contributor

@tongke6 tongke6 commented Jan 20, 2025

What problem does this PR solve?

Issue Number:

Problem Summary:

在最新的 protobuf 版本里,protoc_lib 包含 main 函数,而 //:brpc --> //:mcpack2pb --> @com_google_protobuf//:protoc_lib,导致所有依赖 brpc 的 gtest 且没有显式写 main 函数的测试,实际上运行的是 protoc 的程序。比如issue protocolbuffers/protobuf#12887

这个 PR 尝试解决这个问题,将 //:mcpack2pb 的依赖最小化。

What is changed and the side effects?

Changed:

Side effects:

  • Performance effects(性能影响):
    NO
  • Breaking backward compatibility(向后兼容性): NO compatibility issue.

Check List:

  • Please make sure your changes are compilable(请确保你的更改可以通过编译).
  • When providing us with a new feature, it is best to add related tests(如果你向我们增加一个新的功能, 请添加相关测试).
  • Please follow Contributor Covenant Code of Conduct.(请遵循贡献者准则).

Copy link
Contributor

@chenBright chenBright left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yanglimingcn
Copy link
Contributor

LGTM

@tongke6
Copy link
Contributor Author

tongke6 commented Jan 23, 2025

@chenBright 你好,这个 PR 可以合入了吗?还有什么需要我做的吗?

@chenBright chenBright merged commit d72281f into apache:master Jan 23, 2025
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants