Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix gflag namespace of example and tools #2879

Merged
merged 1 commit into from
Jan 19, 2025

Conversation

chenBright
Copy link
Contributor

What problem does this PR solve?

Issue Number:

Problem Summary:

What is changed and the side effects?

Changed:

接着#2877 ,将tool和example目录的GFLAGS_NS替换成GFLAGS_NAMESPACE。

Side effects:

  • Performance effects(性能影响):

  • Breaking backward compatibility(向后兼容性):


Check List:

  • Please make sure your changes are compilable(请确保你的更改可以通过编译).
  • When providing us with a new feature, it is best to add related tests(如果你向我们增加一个新的功能, 请添加相关测试).
  • Please follow Contributor Covenant Code of Conduct.(请遵循贡献者准则).

@chenBright
Copy link
Contributor Author

@wwbmmm cc

@wwbmmm
Copy link
Contributor

wwbmmm commented Jan 19, 2025

LGTM

@chenBright chenBright merged commit 0608aa1 into apache:master Jan 19, 2025
20 checks passed
@chenBright chenBright deleted the fix_gflag_ns_ branch January 19, 2025 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants