Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add descriptive tags to republished containers #33477

Merged
merged 2 commits into from
Jan 2, 2025

Conversation

damccorm
Copy link
Contributor

@damccorm damccorm commented Jan 2, 2025

This will make identifying things easier. Also tweaked the workflow since it was failing

Example test run: https://github.com/apache/beam/actions/runs/12585577995/job/35077661479 (failing partway through because of unrelated docker issues I'm also looking at)

Example container created: https://pantheon.corp.google.com/artifacts/docker/apache-beam-testing/us/gcr.io/updated_released_container_images%2Fbeam_flink1.17_job_server?e=13802955&mods=-ai_platform_fake_service


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@github-actions github-actions bot added the build label Jan 2, 2025
@damccorm damccorm marked this pull request as ready for review January 2, 2025 19:14
Copy link
Contributor

github-actions bot commented Jan 2, 2025

Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment assign set of reviewers

@damccorm
Copy link
Contributor Author

damccorm commented Jan 2, 2025

assign set of reviewers

Copy link
Contributor

github-actions bot commented Jan 2, 2025

Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer:

R: @Abacn for label build.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

@damccorm damccorm merged commit f3972c7 into master Jan 2, 2025
4 of 5 checks passed
damccorm added a commit that referenced this pull request Jan 2, 2025
* Add descriptive tags to republished containers

* Simplify defaults
@damccorm damccorm deleted the users/damccorm/republishTags branch January 2, 2025 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants