Address testing feedback

NaNs are still excluded from `randFloat16`, as this matches the native float equivalents
apache · Oct 31, 2023 · e414709 · e414709
1 parent 7690928
commit e414709
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 4 deletions.
diff --git a/go/parquet/internal/testutils/random.go b/go/parquet/internal/testutils/random.go
@@ -374,10 +374,9 @@ func randFloat64(r *rand.Rand) float64 {
 // to better spread the values out and ensure we do not return any NaN or Inf values.
 func randFloat16(r *rand.Rand) float16.Num {
 	for {
-		f16 := float16.FromBits(uint16(r.Uint64n(math.MaxUint16 + 1)))
-		f64 := float64(f16.Float32())
-		if !math.IsNaN(f64) && !math.IsInf(f64, 0) {
-			return f16
+		f := float16.FromBits(uint16(r.Uint64n(math.MaxUint16 + 1)))
+		if !f.IsNaN() {
+			return f
 		}
 	}
 }

diff --git a/go/parquet/schema/reflection_test.go b/go/parquet/schema/reflection_test.go
@@ -153,6 +153,7 @@ func ExampleNewSchemaFromStruct_logicaltypes() {
 		BSON                  []byte   `parquet:"logical=BSON"`
 		UUID                  [16]byte `parquet:"logical=uuid"`
 		Float16               [2]byte  `parquet:"logical=float16"`
+		Float16Optional       *[2]byte `parquet:"logical=float16"`
 	}
 
 	sc, err := schema.NewSchemaFromStruct(LogicalTypes{})
@@ -182,6 +183,7 @@ func ExampleNewSchemaFromStruct_logicaltypes() {
 	//   required byte_array field_id=-1 BSON (BSON);
 	//   required fixed_len_byte_array field_id=-1 UUID (UUID);
 	//   required fixed_len_byte_array field_id=-1 Float16 (Float16);
+	//   optional fixed_len_byte_array field_id=-1 Float16Optional (Float16);
 	// }
 }