Add Array::shrink_to_fit(&mut self) to 53.4.0 (#6790) (#6817)
#6962
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add `Array::shrink_to_fit` * Test that shrink_to_fit actually frees memory * Make sure the buffer isn't shared in the test of shrink_to_fit * Remove `#[inline]` * Use `realloc` to reallocate the bytes * Clean up test * Improve docstring for `Array::shrink_to_fit` Co-authored-by: Raphael Taylor-Davies <[email protected]> * `Buffer::shrink_to_fit`: ignore shared buffers * Improve comment in `ArrayRef::shrink_to_fit` * Document why `try_realloc` is safe, and actually make it safe :) * Improve testing of shrink_to_fit * Fix a few corner cases, and improve test * Add license header to new test file --------- Co-authored-by: Raphael Taylor-Davies <[email protected]>
* Support shrink to empty * Docs * Format
emilk
changed the title
Array::shrink_to_fit(&mut self) (#6790) (#6817)Array::shrink_to_fit(&mut self) to 53.4.0 (#6790) (#6817)
|
CI failures are unrelated to the PR - they seem to be because of the recent release of Rust 1.84.0. It is likely best fixed by adding a |
14 tasks
|
We can get this in no problem. I'll try and look at the CI failure later today |
|
This PR should fix the CI on the 53.0.0_maintenance branch: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This cherry-picks the following PRs into the 53.4.0 minor release:
Array::shrink_to_fit(&mut self)#6790This adds a feature that is very important at us at Rerun in order for us to migrate away from arrow2 to arrow-rs without regressing significantly (2x) on memory overhead.
This is pure addition, with no change of existing code, so it is perfectly safe to add to a minor release.
Related