Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor: add comments explaining bad MSRV, output in json #6857

Merged
merged 4 commits into from
Dec 18, 2024
Merged

Minor: add comments explaining bad MSRV, output in json #6857

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
5a8ddd0
Minor: add comments explaining bad MSRV
alamb Dec 7, 2024
61872b6
purposely introduce msrv brek
alamb Dec 7, 2024
788fd84
output in JSON format
alamb Dec 7, 2024
49646ac
Revert "purposely introduce msrv brek"
alamb Dec 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 13 additions & 5 deletions .github/workflows/rust.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,7 +112,7 @@ jobs:
run: cargo fmt --all -- --check

msrv:
name: Verify MSRV
name: Verify MSRV (Minimum Supported Rust Version)
runs-on: ubuntu-latest
container:
image: amd64/rust
Expand All @@ -126,13 +126,19 @@ jobs:
run: cargo update -p ahash --precise 0.8.7
- name: Check arrow
working-directory: arrow
run: cargo msrv --log-target stdout verify
run: |
# run `cd arrow; cargo msrv verify` to see problematic dependencies
cargo msrv verify --output-format=json
- name: Check parquet
working-directory: parquet
run: cargo msrv --log-target stdout verify
run: |
# run `cd parquet; cargo msrv verify` to see problematic dependencies
cargo msrv verify --output-format=json
- name: Check arrow-flight
working-directory: arrow-flight
run: cargo msrv --log-target stdout verify
run: |
# run `cd arrow-flight; cargo msrv verify` to see problematic dependencies
cargo msrv verify --output-format=json
- name: Downgrade object_store dependencies
working-directory: object_store
# Necessary because tokio 1.30.0 updates MSRV to 1.63
Expand All @@ -142,4 +148,6 @@ jobs:
cargo update -p url --precise 2.5.0
- name: Check object_store
working-directory: object_store
run: cargo msrv --log-target stdout verify
run: |
# run `cd object_store; cargo msrv verify` to see problematic dependencies
cargo msrv verify --output-format=json
Loading