-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(parquet): Add support for Page Indexes #223
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(Sorry, I couldn't review this carefully... I took a look at all changes but I don't have enough knowledge of the Parquet specification and Go. And this change is too large for me... I hope that others can review this.)
I'd like to get this in before I kick off the next release in the next week or so. Would anyone be free to do a review soon? |
Thanks for the review @lidavidm!! |
Rationale for this change
Adds support for writing and retrieving Page Indexes from parquet files
What changes are included in this PR?
Added new writer properties to enable writing PageIndexes either as default or for specific columns.
Added
RowGroupPageIndexReader
,ColumnIndexReader
,OffsetIndexReader
to access page index information.Are these changes tested?
Yes, extensive unit tests have been added including round trip tests and encryption/decryption tests.
Are there any user-facing changes?
no. Just new functions available.
closes #33