refactor(opentelemetry): replace plugin attribute with plugin metadata #11940
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
size:L
moonming
previously approved these changes
Jan 26, 2025
membphis
previously approved these changes
Jan 27, 2025
apisix/plugins/opentelemetry.lua
Outdated
| @@ -192,18 +192,20 @@ local _M = { | |||
| priority = 12009, | |||
| name = plugin_name, | |||
| schema = schema, | |||
| attr_schema = attr_schema, | |||
| metadata_schema = metadata_schema, | |||
There was a problem hiding this comment.
code style:
Suggested change
| metadata_schema = metadata_schema, | |
| metadata_schema = metadata_schema, |
dosubot
bot
added
size:XL
| }, | ||
| "set_ngx_var": false | ||
| } | ||
| }' | ||
| ``` | ||
|
|
||
| Reload APISIX for changes to take effect. |
There was a problem hiding this comment.
do we really need reload now?
conf/config.yaml.example
Outdated
| @@ -444,7 +444,7 @@ plugins: # plugin list (sorted by priority) | |||
| - request-id # priority: 12015 | |||
| - zipkin # priority: 12011 | |||
| #- skywalking # priority: 12010 | |||
| #- opentelemetry # priority: 12009 | |||
| - opentelemetry # priority: 12009 | |||
There was a problem hiding this comment.
why do we need this change?
shreemaan-abhishek
approved these changes
Jan 27, 2025
membphis
approved these changes
Jan 28, 2025
moonming
approved these changes
Jan 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR replaces plugin attribute with plugin metadata in Opentelemetry plugin. Now the same configuration will have to be passed with plugin metadata and not attribute.
Fixes # (issue)
Checklist