Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(jwt-auth): disallow empty key configuration attributes #11852

Merged
merged 1 commit into from
Dec 26, 2024
Merged

fix(jwt-auth): disallow empty key configuration attributes #11852

merged 1 commit into from
Dec 26, 2024

Conversation

shreemaan-abhishek
Copy link
Contributor

Description

key and secret attributes should not be allowed to be configured empty.

Checklist

  • I have explained the need for this PR and the problem it solves
  • I have explained the changes or the new features added to this PR
  • I have added tests corresponding to this change
  • I have updated the documentation to reflect this change
  • I have verified that this change is backward compatible (If not, please discuss on the APISIX mailing list first)

@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. bug Something isn't working labels Dec 24, 2024
@shreemaan-abhishek shreemaan-abhishek merged commit b62d59d into apache:master Dec 26, 2024
29 of 30 checks passed
@shreemaan-abhishek shreemaan-abhishek deleted the jwt-auth-schema-update branch December 26, 2024 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Revolyssup Revolyssup Revolyssup approved these changes

@moonming moonming moonming approved these changes

@nic-6443 nic-6443 nic-6443 approved these changes

Assignees
No one assigned
Labels
bug Something isn't working size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@shreemaan-abhishek @nic-6443 @moonming @Revolyssup