Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: workflow plugin registration #11832

Merged
merged 2 commits into from
Dec 17, 2024

Conversation

Revolyssup
Copy link
Contributor

@Revolyssup Revolyssup commented Dec 16, 2024

Description

Fixes # (issue)
Current logic requires the table supported_actions defined in workflow.lua to be changed when any new plugin is added to the workflow plugin. With this change, the registration in the table is offloaded to the newly added plugin by implementing the function workflow_handler()

Checklist

  • I have explained the need for this PR and the problem it solves
  • I have explained the changes or the new features added to this PR
  • I have added tests corresponding to this change
  • I have updated the documentation to reflect this change
  • I have verified that this change is backward compatible (If not, please discuss on the APISIX mailing list first)

@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. plugin tech debt labels Dec 16, 2024
Copy link
Member

@membphis membphis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we need to add any new test cases?

@Revolyssup
Copy link
Contributor Author

do we need to add any new test cases?

This is just a refactor. Functionality is already covered in existing test cases. This is internal logic change. So I dont think test cases are needed

@Revolyssup Revolyssup merged commit 44391e0 into apache:master Dec 17, 2024
30 checks passed
@Revolyssup Revolyssup deleted the revolyssup/switch-dependency branch December 17, 2024 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
plugin size:M This PR changes 30-99 lines, ignoring generated files. tech debt
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants