-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: add redirect_after_logout_uri for ODIC that do not have an end_session_endpoint #10653
fix: add redirect_after_logout_uri for ODIC that do not have an end_session_endpoint #10653
Conversation
|
It's not necessary to add documentation, this PR is just to support services like Google that don't provide the end_session_endpoint configuration, and OIDC can also correctly using the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can not merge without test cases
t/plugin/openid-connect.t
Outdated
|
||
|
||
|
||
=== TEST 35: Check whether outh0 can redirect normally using post_logout_redirect_uri configuration |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
auth0
…isix into ODIC_redirect_after_logout
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
great job
@luoluoyuyu a question for the below: What if someone configures both https://github.com/zmartzone/lua-resty-openidc/blob/master/tests/spec/logout_spec.lua#L264-L299 |
Hi @kayx23 'redirect_after_logout_uri' is not defined in the schema. If 'redirect_after_logout_uri' is configured, an error will occur. apisix/apisix/plugins/openid-connect.lua at master · apache/apisix (github.com) |
Description
Fixes #6791
Problem Analysis
When the openid service does not support
end_session_endpoint
, the ODIC logout fails to redirect to post_logout_redirect_uri. this issue is caused by the OpenID standard.end_session_endpoint
does not necessarily need to be implemented.Solution
Use the
redirect_after_logout_uri
defined in lua-resty-openidc for redirection when the OpenID service does not supportend_session_endpoint
.Checklist