Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add brotli plugin #10515
feat: add brotli plugin #10515
Changes from 27 commits
46dbb82
10b97cf
8b42bf6
2e55cb6
c682922
86eab3d
ddea9bd
d36558f
299e719
b5f1de7
dacf773
d5ee1e8
f7f44cf
3d3117b
fe62e46
dee5fb6
c494021
940382f
2f9c3c7
8f76ef6
f064a5f
75bb0cf
c5e5d08
b959f11
8be4f80
b1c3f30
92d3461
111813a
ea83d7e
a63f239
fa6aaf1
cd8f323
e28bf8d
1c179e1
9640cbc
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
how about checking content-type before
check_accept_encoding
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should check accept encoding first, if request not allow this encoding, we don't need to check our conf.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"*"
cannot match any MIME type.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if we use
"*"
in"types"
, it will pass this "ipairs", and will setbrotli_matched
astrue
in this func. same as 'gzip' plugin.