docs: add IngressClassName to ApisixRoute spec
#2246
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kayx23
commented
Jun 17, 2024
| @@ -35,6 +35,7 @@ The table below describes each of the attributes in the spec. The fields `apiVer | |||
|
|
|||
| | Attribute | Type | Description | | |||
| |--------------------------------------|--------------------|---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------| | |||
| | ingressClassName | string | Name of the ingress class. Used to target a specific controller that should implement the resource. | | |||
There was a problem hiding this comment.
Unsure if v2beta3 API needs this update.
pottekkat
reviewed
Jun 19, 2024
There was a problem hiding this comment.
LGTM.
You don't need to update the v2beta3 doc. In fact, I think we can remove these "beta" API docs entirely, as they are no longer needed.
cc: @Revolyssup
I thought so too seeing some previous discussions but need confirmation. |
|
@kayx23 I checked with @Revolyssup. We can remove these as the v2beta3 APIs are no longer in the CRDs. |
|
I reverted the change for |
Revolyssup
approved these changes
Jul 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change:
What this PR does / why we need it:
Closes #2201
Add
IngressClassNametoApisixRoutespec.Pre-submission checklist: