Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Upgrade to Gateway API v1 #2148

Closed
wants to merge 46 commits into from

Conversation

Revolyssup
Copy link
Contributor

@Revolyssup Revolyssup commented Jan 25, 2024

Type of change:

  • Bugfix
  • New feature provided
  • Improve performance
  • Backport patches
  • Documentation
  • Refactor
  • Chore
  • CI/CD or Tests

What this PR does / why we need it:

Pre-submission checklist:

  • Did you explain what problem does this PR solve? Or what new features have been added?
  • Have you added corresponding test cases?
  • Have you modified the corresponding document?
  • Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first

@Revolyssup Revolyssup marked this pull request as draft January 25, 2024 08:02
@codecov-commenter
Copy link

codecov-commenter commented Jan 25, 2024

Codecov Report

Attention: 126 lines in your changes are missing coverage. Please review.

Comparison is base (16a22d3) 37.38% compared to head (5c919d9) 36.96%.

❗ Current head 5c919d9 differs from pull request most recent head 31757e5. Consider uploading reports for the commit 31757e5 to get more accurate results

Files Patch % Lines
pkg/providers/gateway/translation/gateway.go 0.00% 97 Missing ⚠️
pkg/providers/utils/ingress_status.go 0.00% 20 Missing ⚠️
...providers/gateway/translation/gateway_httproute.go 46.15% 7 Missing ⚠️
pkg/config/config.go 66.66% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2148      +/-   ##
==========================================
- Coverage   37.38%   36.96%   -0.43%     
==========================================
  Files          94       94              
  Lines        7971     8076     +105     
==========================================
+ Hits         2980     2985       +5     
- Misses       4597     4697     +100     
  Partials      394      394              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Revolyssup Revolyssup marked this pull request as ready for review January 29, 2024 17:01
@Revolyssup Revolyssup changed the title [DRAFT] chore: Upgrade to Gateway API v1 chore: Upgrade to Gateway API v1 Jan 29, 2024
@@ -180,8 +187,15 @@ var _ = ginkgo.Describe("suite-chore: Consistency between APISIX and the Ingress

s.NewAPISIXClient().GET("/ip").WithHeader("Host", "httpbin.org").Expect().Status(http.StatusOK)
})

if os.Getenv("K8S_VERSION") == "v1.29.0" {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We may be able to obtain the k8 version through the API. please ref:
https://pkg.go.dev/k8s.io/[email protected]/discovery#DiscoveryClient.ServerVersion

image

k8s version >= v1.25

@AlinsRan
Copy link
Contributor

AlinsRan commented Feb 1, 2024

Oh..
There are too many workflow jobs, maybe we can integrate them in the future.

Copy link

github-actions bot commented Apr 9, 2024

This pull request has been marked as stale due to 60 days of inactivity. It will be closed in 30 days if no further activity occurs. If you think that's incorrect or this pull request should instead be reviewed, please simply write any comment. Even if closed, you can still revive the PR at any time or discuss it on the [email protected] list. Thank you for your contributions.

@github-actions github-actions bot added the stale label Apr 9, 2024
Copy link

github-actions bot commented May 9, 2024

This pull request/issue has been closed due to lack of activity. If you think that is incorrect, or the pull request requires review, you can revive the PR at any time.

@github-actions github-actions bot closed this May 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants