-
Notifications
You must be signed in to change notification settings - Fork 355
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Upgrade to Gateway API v1 #2148
Conversation
Signed-off-by: Ashish Tiwari <[email protected]>
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #2148 +/- ##
==========================================
- Coverage 37.38% 36.96% -0.43%
==========================================
Files 94 94
Lines 7971 8076 +105
==========================================
+ Hits 2980 2985 +5
- Misses 4597 4697 +100
Partials 394 394 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Ashish Tiwari <[email protected]>
test/e2e/suite-chore/consistency.go
Outdated
@@ -180,8 +187,15 @@ var _ = ginkgo.Describe("suite-chore: Consistency between APISIX and the Ingress | |||
|
|||
s.NewAPISIXClient().GET("/ip").WithHeader("Host", "httpbin.org").Expect().Status(http.StatusOK) | |||
}) | |||
|
|||
if os.Getenv("K8S_VERSION") == "v1.29.0" { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We may be able to obtain the k8 version through the API. please ref:
https://pkg.go.dev/k8s.io/[email protected]/discovery#DiscoveryClient.ServerVersion
k8s version >= v1.25
Oh.. |
This pull request has been marked as stale due to 60 days of inactivity. It will be closed in 30 days if no further activity occurs. If you think that's incorrect or this pull request should instead be reviewed, please simply write any comment. Even if closed, you can still revive the PR at any time or discuss it on the [email protected] list. Thank you for your contributions. |
This pull request/issue has been closed due to lack of activity. If you think that is incorrect, or the pull request requires review, you can revive the PR at any time. |
Type of change:
What this PR does / why we need it:
Pre-submission checklist: