Stop reserializing DAGs during db migration #45362
Merged
+9
−41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
At first, this may seem strange, but we already have to deal with older versions of serialized DAGs - so the necessity of reserializing during migrations isn't there any longer. The DAG processor can simply do it once Airflow has started back up.
1 task
dstandish
approved these changes
Jan 2, 2025
potiuk
approved these changes
Jan 2, 2025
|
Failure is unrelated (see #45329). |
LefterisXefteris
pushed a commit
to LefterisXefteris/airflow
that referenced
this pull request
Jan 5, 2025
At first, this may seem strange, but we already have to deal with older versions of serialized DAGs - so the necessity of reserializing during migrations isn't there any longer. The DAG processor can simply do it once Airflow has started back up.
agupta01
pushed a commit
to agupta01/airflow
that referenced
this pull request
Jan 6, 2025
At first, this may seem strange, but we already have to deal with older versions of serialized DAGs - so the necessity of reserializing during migrations isn't there any longer. The DAG processor can simply do it once Airflow has started back up.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At first, this may seem strange, but we already have to deal with older versions of serialized DAGs - so the necessity of reserializing during migrations isn't there any longer. The DAG processor can simply do it once Airflow has started back up.p
I've opened #45361 as a check point, once the dust has settled, to see if we need to add it back.