Cleanup some (old) tasks UI tests #45352
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These tests don't need to use a dedicated DAG, plus this is the only use of DAGs from the tests dag dir, which means we can later switch to only parsing the example DAGs. This also removes a couple leftover DAG code related tests that aren't needed anymore - all DAG code comes from the db, and we parse/store example DAGs all over the place, so no extra value with these tests. Why am I touching old UI stuff? My parsing changes for DAG bundles breaks a bunch of these tests, and we aren't quite ready to remove the old UI...
potiuk
approved these changes
Jan 2, 2025
LefterisXefteris
pushed a commit
to LefterisXefteris/airflow
that referenced
this pull request
Jan 5, 2025
These tests don't need to use a dedicated DAG, plus this is the only use of DAGs from the tests dag dir, which means we can later switch to only parsing the example DAGs. This also removes a couple leftover DAG code related tests that aren't needed anymore - all DAG code comes from the db, and we parse/store example DAGs all over the place, so no extra value with these tests. Why am I touching old UI stuff? My parsing changes for DAG bundles breaks a bunch of these tests, and we aren't quite ready to remove the old UI...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(let's try #45335 again)
These tests don't need to use a dedicated DAG, plus this is the only use of DAGs from the tests dag dir, which means we can later switch to only parsing the example DAGs.
This also removes a couple leftover DAG code related tests that aren't needed anymore - all DAG code comes from the db, and we parse/store example DAGs all over the place, so no extra value with these tests.
Why am I touching old UI stuff? My parsing changes for DAG bundles breaks a bunch of these tests, and we aren't quite ready to remove the old UI...