Move Literal alias into TYPE_CHECKING block #45345
Open
+69
−43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
area:CLI
area:providers
provider:amazon-aws
uranusjr
force-pushed
the
improve-literal
branch
from
746a83e to
027559e
Compare
This allows us to always import Literal from typing, which has received quite some bug fixes between different versions. Doing this in the typing block avoids loading the runtime version at all, thus eliminating differences between runtime Python versions.
uranusjr
force-pushed
the
improve-literal
branch
from
027559e to
a7ae2e7
Compare
uranusjr
force-pushed
the
improve-literal
branch
from
9f9b343 to
8d236ad
Compare
eladkal
approved these changes
Jan 3, 2025
shahar1
approved these changes
Jan 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows us to always import Literal from typing, which has received quite some bug fixes between different versions. Doing this in the typing block avoids loading the runtime version at all, thus eliminating differences between runtime Python versions.