-
Notifications
You must be signed in to change notification settings - Fork 14.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(databricks): update DatabricksJobRunLink for improved XCom handlin #45328
fix(databricks): update DatabricksJobRunLink for improved XCom handlin #45328
Conversation
- Refactored the DatabricksJobRunLink class to include a more robust implementation for retrieving the job run URL from XCom. - Updated to utilize XCom.get_value for improved clarity and maintainability. - Enhanced error handling to prevent issues when the XCom key does not exist. - Added detailed comments to clarify logic and improve readability. This change ensures better alignment with Airflow's standards for operator links and enhances the reliability of job run URL retrieval.
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
|
You need to add unit tests exhibiting and testing the new behaviour |
@potiuk i don't understand can u explain more how can I do this and what I need to edit |
Add unit tests: Look at our Contributing docs - particularly testing - you can also look at other PRs for reference. We practically never accept PRs that have no accompanying unit tests and you need to learn how to write and run them if you want to contribute. Our contribution guides have quick-starts for various IDEs and when you follow them you can have working development environment where you can run unit tests in less than 10 minutes. |
Fix Databricks Extra Link to See Job Run with Custom S3 Backend
Problem Addressed
This PR addresses the issue described in #45240, where the Databricks Extra Link for "See Job Run" does not work when using a custom XCom backend that writes to S3. Specifically:
Proposed Changes
DatabricksJobRunLink
implementation to reliably fetch the Databricks job run URL from XCom usingXCom.get_value
.Key Benefits
Testing
Issue Link
Closes #45240.
Checklist
Code of Conduct
I agree to follow this project's Code of Conduct.