-
Notifications
You must be signed in to change notification settings - Fork 14.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename fail stop dag property to fail fast #45327
base: main
Are you sure you want to change the base?
Rename fail stop dag property to fail fast #45327
Conversation
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
|
@hprassad FYI, I updated your PR description to link the issue. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall, I'm good with this PR, but we'll need a newsfragment for it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are a couple of occurences which have been missed in tests.
Ref:
Also, needs a newsfragment addition. Example: https://github.com/apache/airflow/pull/43902/files#diff-802ca1cc091ad2e4489cfdb8cb02678d0bc42db3a6b9081859a2ee66b415b94e
@Lee-W do we have to add this one into migration rules too? |
Yes, this can be easily detected. I’ll create a PR for this later |
b92cd31
to
d108d45
Compare
…-fail_fast' into rename-fail_stop-DAG-property-to-fail_fast # Conflicts: # task_sdk/src/airflow/sdk/definitions/dag.py
…-fail_fast' into rename-fail_stop-DAG-property-to-fail_fast # Conflicts: # task_sdk/src/airflow/sdk/definitions/dag.py
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we'll need newsfragment for this one
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
…-fail_fast' into rename-fail_stop-DAG-property-to-fail_fast
@amoghrajesh & @Lee-W , I have added file in newsfragments folder for the PR |
closes: #45229
This PR renames fail_stop DAG property to fail_fast, the changes made to relevant files
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rst
or{issue_number}.significant.rst
, in newsfragments.