[draft] AIP-72: call on_task_instance_* listeners #45294
Draft
+1,796
−790
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
area:Executors-core
mobuchowski
force-pushed
the
tasksdk-call-listeners
branch
4 times, most recently
from
f07a78e to
81b886b
Compare
|
@mobuchowski - can you please rebase that one -> we found and issue with @jscheffl with the new caching scheme - fixed in #45347 that would run "main" version of the tests. I am asking in all affected PRs to rebase. |
potiuk
force-pushed
the
tasksdk-call-listeners
branch
from
81b886b to
15fd95a
Compare
|
Actually - I rebased it now. |
|
I will rebase very soon as I'm working on some of the test failures anyway 🙂 |
mobuchowski
force-pushed
the
tasksdk-call-listeners
branch
3 times, most recently
from
a24010b to
db45617
Compare
Signed-off-by: Maciej Obuchowski <[email protected]>
mobuchowski
force-pushed
the
tasksdk-call-listeners
branch
from
db45617 to
88a2414
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With AIP-72, there is no access to the database session from the worker process, and the runtime objects have some differences to the db models. This adjusts the initial structure to naively call the listeners.