Fix HTTP 500 error on updating same task instance state via FastAPI PATCH taskinstance/{task} endpoint #45288
+50
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vatsrahul1001
requested review from
ephraimbuddy and
pierrejeambrun
as code owners
vatsrahul1001
requested review from
bbovenzi,
ryanahamilton and
jscheffl
as code owners
amoghrajesh
approved these changes
Dec 30, 2024
tests/api_fastapi/core_api/routes/public/test_task_instances.py
Outdated
Show resolved
Hide resolved
…ow into fix-patch-task-instance
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During AIP-84 testing, we noticed an HTTP 500 error when providing the same task state for the FastAPI PATCH taskinstance/{task} endpoint.
In comparison, the legacy API does not exhibit this issue. Upon investigation, the failure occurs on this line. When the same state is provided, the tis_altered variable returns None, which results in tis also being None.
Further inspection revealed that ti should actually be tis. Additionally, since HTTP 404 is already handled here, it would be more appropriate to raise an HTTP 409 error in this case.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.