Add group_display_name attribute to allow specifying a custom display name in the UI for TaskGroup
#45264
Conversation
hardeybisey
force-pushed
the
accept_group_display_name_in_taskgroup
branch
from
2d7a6e8 to
85e2bb3
Compare
There was a problem hiding this comment.
Thanks for the contribution! I always wanted to make this but the big shift to Airflow 3 distracted me from making this...
Once check that we need to discuss on attribute model...
... and besides this, would it make sense to consider adding UI changes in the same PR as well? Else the group display name would have no effect other than just adding an attribute.
Thank you for taking the time to review this and for your thoughtful feedback! To clarify, when you mention the display name having no effect, are you suggesting it doesn’t currently reflect in the UI? In this implementation, when the group display name is provided, it is displayed in the UI as expected as shown below. 
Regarding the UI changes, I’d be happy to extend this PR to also include a new Group Display Name key as part of the task group details on this page if that is what you are suggesting. Please let me know the direction you’d like me to proceed. Thank you! |
Oh, did not notice that UI changed w/o touching the code. Cool. |
Thanks for the feedback! Just to confirm, does this mean the PR is ready to go and meets the current requirements? Also, I’m happy to contribute to other areas that are not UI-related, as I’m not an expert with frontend libraries or code 😄 |
hardeybisey
force-pushed
the
accept_group_display_name_in_taskgroup
branch
from
85e2bb3 to
b1b3d1b
Compare
…ay name in the UI for TaskGroup (apache#45264) * Add group_display_name attribute to allow specifying a custom display name in the UI for TaskGroup * Add new tests and update old test to suppport the changes made.
…ay name in the UI for TaskGroup (apache#45264) * Add group_display_name attribute to allow specifying a custom display name in the UI for TaskGroup * Add new tests and update old test to suppport the changes made.
…ay name in the UI for TaskGroup (apache#45264) * Add group_display_name attribute to allow specifying a custom display name in the UI for TaskGroup * Add new tests and update old test to suppport the changes made.
closes: #44569
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.