Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename fail_stop DAG property to fail_fast #45229

Open
amoghrajesh opened this issue Dec 27, 2024 · 6 comments · May be fixed by #45327
Open

Rename fail_stop DAG property to fail_fast #45229

amoghrajesh opened this issue Dec 27, 2024 · 6 comments · May be fixed by #45327
Assignees
@hprassad
Labels
area:core good first issue kind:feature Feature Requests

Comments

@amoghrajesh
Copy link
Contributor

amoghrajesh commented Dec 27, 2024 •
edited
Loading

Body

fail_stop isn't a good name at all. The property isn't indicative of the purpose. The original PR #29406 intended to call it fail_fast which is much better.
@dosubot dosubot bot added area:core kind:feature Feature Requests labels Dec 27, 2024
@hprassad
Copy link

hprassad commented Dec 27, 2024 •
edited
Loading

Hi @amoghrajesh , I would like to work on this. Can you please assign this to me ?

@amoghrajesh
Copy link
Contributor Author

Feel free @hprassad.

We will need a deprecation for 2.11 and then we will have to start using the new property name for 3.x onwards (main branch). Example for deprecations #44791

@amoghrajesh
Copy link
Contributor Author

@hprassad are you still working on this issue? Do you need any assistance?

@hprassad
Copy link

@amoghrajesh, Yes, i'm working on this. Any assistance would be helpful

hprassad added a commit to hprassad/airflow that referenced this issue Jan 1, 2025
@hprassad
Renamed fail_stop DAG property to fail_fast (apache#45229)
ce97648
@amoghrajesh
Copy link
Contributor Author

As discussed offline, please proceed with a pull request, and we can discuss further there.

@hprassad
Copy link

hprassad commented Jan 1, 2025

Hi @amoghrajesh , PR is raised

@amoghrajesh amoghrajesh linked a pull request Jan 2, 2025 that will close this issue
Open
potiuk pushed a commit to hprassad/airflow that referenced this issue Jan 2, 2025
@hprassad @potiuk
Renamed fail_stop DAG property to fail_fast (apache#45229)
d108d45
hprassad added a commit to hprassad/airflow that referenced this issue Jan 2, 2025
@hprassad
made changes to missed occurences (apache#45229)
2e2d8fc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hprassad hprassad

Labels
area:core good first issue kind:feature Feature Requests
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Rename fail stop dag property to fail fast hprassad/airflow
2 participants
@amoghrajesh @hprassad