Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename fail stop dag property to fail fast #45327

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Rename fail stop dag property to fail fast #45327

wants to merge 7 commits into from
+56 −55

Conversation

hprassad
Copy link

@hprassad hprassad commented Jan 1, 2025 •
edited by amoghrajesh
Loading

closes: #45229
This PR renames fail_stop DAG property to fail_fast, the changes made to relevant files

^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@hprassad hprassad requested review from XD-DENG and ashb as code owners January 1, 2025 14:05
@boring-cyborg boring-cyborg
Copy link

boring-cyborg bot commented Jan 1, 2025

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
Here are some useful points:

  • Pay attention to the quality of your code (ruff, mypy and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
  • Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: [email protected]
    Slack: https://s.apache.org/airflow-slack

@amoghrajesh
Copy link
Contributor

@hprassad FYI, I updated your PR description to link the issue.

@Lee-W Lee-W added the airflow3.0:breaking Candidates for Airflow 3.0 that contain breaking changes label Jan 2, 2025
Lee-W
Lee-W reviewed Jan 2, 2025
View reviewed changes
Copy link
Member

@Lee-W Lee-W left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, I'm good with this PR, but we'll need a newsfragment for it

amoghrajesh
amoghrajesh reviewed Jan 2, 2025
View reviewed changes
Copy link
Contributor

@amoghrajesh amoghrajesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are a couple of occurences which have been missed in tests.
Ref:
image

Also, needs a newsfragment addition. Example: https://github.com/apache/airflow/pull/43902/files#diff-802ca1cc091ad2e4489cfdb8cb02678d0bc42db3a6b9081859a2ee66b415b94e

@amoghrajesh
Copy link
Contributor

@Lee-W do we have to add this one into migration rules too?

@Lee-W
Copy link
Member

Lee-W commented Jan 2, 2025

@Lee-W do we have to add this one into migration rules too?

Yes, this can be easily detected. I’ll create a PR for this later

@potiuk potiuk force-pushed the rename-fail_stop-DAG-property-to-fail_fast branch from b92cd31 to d108d45 Compare January 2, 2025 12:37
@potiuk
Copy link
Member

potiuk commented Jan 2, 2025

@hprassad - I rebased it -> we found and issue with @jscheffl with the new caching scheme - fixed in #45347 that would run "main" version of the tests.

@hprassad
made changes to missed occurences (apache#45229)
2e2d8fc
@hprassad
Merge remote-tracking branch 'origin/rename-fail_stop-DAG-property-to…
ed447ea 
…-fail_fast' into rename-fail_stop-DAG-property-to-fail_fast

# Conflicts:
#	task_sdk/src/airflow/sdk/definitions/dag.py
@hprassad
Merge remote-tracking branch 'origin/rename-fail_stop-DAG-property-to…
d1d1c2e 
…-fail_fast' into rename-fail_stop-DAG-property-to-fail_fast

# Conflicts:
#	task_sdk/src/airflow/sdk/definitions/dag.py
@hprassad hprassad requested review from amoghrajesh and Lee-W January 2, 2025 14:08
Lee-W
Lee-W reviewed Jan 3, 2025
View reviewed changes
Copy link
Member

@Lee-W Lee-W left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we'll need newsfragment for this one

https://github.com/apache/airflow/blob/main/contributing-docs/16_contribution_workflow.rst#step-4-prepare-pr

amoghrajesh
amoghrajesh reviewed Jan 3, 2025
View reviewed changes
Copy link
Contributor

@amoghrajesh amoghrajesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah the changes look good @hprassad. Can you please add newsfragment as mentioned by @Lee-W?

@hprassad
Copy link
Author

hprassad commented Jan 3, 2025

@amoghrajesh & @Lee-W , I have added file in newsfragments folder for the PR

@hprassad hprassad requested review from amoghrajesh and Lee-W January 4, 2025 06:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@XD-DENG XD-DENG Awaiting requested review from XD-DENG XD-DENG is a code owner

@ashb ashb Awaiting requested review from ashb ashb is a code owner

@uranusjr uranusjr Awaiting requested review from uranusjr

@amoghrajesh amoghrajesh Awaiting requested review from amoghrajesh

@Lee-W Lee-W Awaiting requested review from Lee-W

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
airflow3.0:breaking Candidates for Airflow 3.0 that contain breaking changes area:task-sdk
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Rename fail_stop DAG property to fail_fast
4 participants
@hprassad @amoghrajesh @Lee-W @potiuk