ARTEMIS-5338 AckManager flow control #5546
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
there's a bug.. I'm adding a test to verify it and fix it |
clebertsuconic
force-pushed
the
ack-manager-flow-control
branch
2 times, most recently
from
fb2e0d9 to
5b7bfb8
Compare
clebertsuconic
force-pushed
the
ack-manager-flow-control
branch
from
5b7bfb8 to
fe9732c
Compare
clebertsuconic
force-pushed
the
ack-manager-flow-control
branch
4 times, most recently
from
710eda6 to
cc58ce3
Compare
Say there are too many records in the JournalHashMap. In that case the sender should pace sending more data. The target should limit credits when the configured max pending records is reached.
clebertsuconic
force-pushed
the
ack-manager-flow-control
branch
from
cc58ce3 to
1a462dd
Compare
|
I am adding another related commit into this, exposing the number of records... I almost squashed it into the same commit to be honest but since these are separate JIRAs I am keeping it separate. if anyone prefers to be squashed I can do it. |
clebertsuconic
force-pushed
the
ack-manager-flow-control
branch
from
65691bb to
7a0f826
Compare
clebertsuconic
force-pushed
the
ack-manager-flow-control
branch
from
7a0f826 to
fc1f528
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Say there are too many records in the JournalHashMap. In that case the sender should pace sending more data. The target should limit credits when the configured max pending records is reached.