override sysvars from accounts list #61
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this is a convenience to make porting stake_instruction.rs tests (and other similar
InvokeContext
-based tests) much simpler. sysvars from the accounts list are used to override the sysvars onMollusk
, without mutating it. this is to accord with the way existing tests are structured, so we dont need to add any setup logic that doesnt already exist. in general they create sysvar states and pass them intoInvokeContext
viaprocess_instruction
directlyi considered letting it mutate
Sysvars
but this seems cleaner, especially since we will be able to remove it someday when the bpf programs use sysvar syscalls and dont need to accept sysvar accounts at all