Skip to content

Commit

Permalink
Lighthouse best practices audit: short_name (vuejs-templates#63)
Browse files Browse the repository at this point in the history
Should inform the user about the Lighthouse recommendation of Best Practices, rather than implicitly applying the "name" as "short_name".
> Manifest's short_name Won't Be Truncated When Displayed on Homescreen ([Lighthouse](https://developers.google.com/web/tools/lighthouse/audits/manifest-short_name-is-not-truncated))
  • Loading branch information
Lucas S. B. Mastella authored and addyosmani committed Aug 4, 2017
1 parent 63e795d commit e1a9e9a
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 1 deletion.
5 changes: 5 additions & 0 deletions meta.js
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,11 @@ module.exports = {
"required": true,
"message": "Project name"
},
"short_name": {
"type": "string",
"required": false,
"message": "Project short name: fewer than 12 characters to not be truncated on homescreens (default: same as name)",
},
"description": {
"type": "string",
"required": false,
Expand Down
2 changes: 1 addition & 1 deletion template/static/manifest.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "{{ name }}",
"short_name": "{{ name }}",
"short_name": "{{#if short_name }}{{ short_name }}{{else}}{{ name }}{{/if}}",
"icons": [
{
"src": "/static/img/icons/android-chrome-192x192.png",
Expand Down

0 comments on commit e1a9e9a

Please sign in to comment.