ci: Disable no-commit-to-branch @ GHA
#748
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This turns off the "is push to master" in GitHub Actions CI/CD as it does not make sense in this environment, being local-only [[1]]. [1]: pre-commit/pre-commit-hooks#1124
5 tasks
MaxymVlasov
approved these changes
Jan 8, 2025
MaxymVlasov
reviewed
Jan 8, 2025
This might work, but there's a change it would be parsed weirdly. Though, it shouldn't be a factor in the way how pre-commit processes it. Co-authored-by: Maksym Vlasov <[email protected]>
This reverts commit 9c58ad5.
|
@MaxymVlasov it breaks in a different place. I reverted it. |
MaxymVlasov
changed the title
no-commit-to-branch @ GHAno-commit-to-branch @ GHA
|
sad emoji |
|
This PR is included in version 1.97.0 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This turns off the "is push to master" in GitHub Actions CI/CD as it does not make sense in this environment, being local-only [1].
Put an
xinto the box if that apply:Description of your changes
This is a follow-up for #742. One of its jobs runs
pre-commitand doesn't filter out this hook. The hook itself would only fail on pushes tomasterwhich is not a condition that can happen in PR workflow runs.How can we test changes
You can't. This will only be visible on
master.