Add simple cron scheduling #22
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MrIceman
suggested changes
Jul 7, 2024
| } | ||
|
|
||
| func (s *Scheduler) Start(ctx context.Context) { | ||
| s.logger.Printf("Starting CRON scheduling with [%d] jobs.", len(s.jobs)) |
There was a problem hiding this comment.
You might want to have a look attimers, you could just create a new timer for each cron job which would probably simplify your code even more
https://gobyexample.com/timers
There was a problem hiding this comment.
I do not think it will necessarily simplify the code more than what it is, the body of it gorountine when dispacting a job will practically the same with replacing the time.sleep with a listening to the timer channel.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR draft sets up basic cron scheduling. Currently only basic cron strings are accepted, i.e. numerics, wildcards, and steps.
Example usage within a main file can be seen below:
Currently, there is no support for specifiying specific days, i.e., Mon, Tue, Wed, Etc..