Implemented APIs related to block retrieval (aside from proper error responses) #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes implement getting the latest block, getting a block by height, and getting a block by hash.
These changes do not include error handling. I was not able to see any examples of existing HTTP error handling (e.g. returning 404) in the code so I'm not sure how you want to go about that. For now these calls simply return a 'Block not found' string that definitely should be a proper 404.
Finally, since I cannot read Chinese these changes have not been tested. I tried to guess what the readme says but I was not successful in getting my environment properly setup.