Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAINT: Add support for Python 3.13 #481

Merged
merged 4 commits into from
Jan 6, 2025
Merged

MAINT: Add support for Python 3.13 #481

merged 4 commits into from
Jan 6, 2025

Conversation

ansjmoody
Copy link
Collaborator

Description

Add support for Python 3.13. Remove some references to Python 3.8 and 3.9

Issue linked

#460

Checklist:

  • [] Run unit tests and make sure they all pass
    - Run tests without Sherlock running
    - Run tests with Sherlock GRPC connection
  • [] Check and fix style errors
    - pre-commit command line check
    - Problems tab in PyCharm
  • [] Bench test new/modified APIs by using and modifying the code in the example for the API method
  • [] Add new classes to rst files, located at: \doc\source\api
  • [] Generate documentation
  • [] Verify the HTML. It gets generated at: \doc\build\html.
    - Open index.html
    - Click on "API Reference" at the top.
    - Verify HTML for API changes.
  • [] Check that test code coverage is at least 80% when Sherlock is running
  • [] Make sure that the title of the pull request follows Commit naming conventions (e.g. feat: adding new PySherlock command)

@github-actions github-actions bot added dependencies Related with project dependencies maintenance Package and maintenance related labels Jan 3, 2025
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Jan 3, 2025
@ansjmoody ansjmoody changed the title Add support for Python 3.13. Remove some references to Python 3.8 and 3.9 MAINT: Add support for Python 3.13. Remove some references to Python 3.8 and 3.9 Jan 3, 2025
@ansjmoody ansjmoody requested a review from RobPasMue January 3, 2025 21:24
@ansjmoody ansjmoody changed the title MAINT: Add support for Python 3.13. Remove some references to Python 3.8 and 3.9 MAINT: Add support for Python 3.13 Jan 3, 2025
@ansjmoody ansjmoody enabled auto-merge (squash) January 3, 2025 21:27
Copy link

codecov bot commented Jan 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.07%. Comparing base (2b562b9) to head (5d86bb3).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #481      +/-   ##
==========================================
- Coverage   60.25%   60.07%   -0.19%     
==========================================
  Files          23       21       -2     
  Lines        5032     5009      -23     
==========================================
- Hits         3032     3009      -23     
  Misses       2000     2000              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ansjmoody ansjmoody merged commit f50e12e into main Jan 6, 2025
30 of 31 checks passed
@ansjmoody ansjmoody deleted the jeff/python3.13 branch January 6, 2025 19:27
@ansjmoody ansjmoody added this to the v0.9.0 milestone Jan 6, 2025
@ansjmoody ansjmoody linked an issue Jan 6, 2025 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Related with project dependencies documentation Improvements or additions to documentation maintenance Package and maintenance related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[MAINTENANCE] Support for Python 3.13
3 participants