Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added polyline simplification to import_odb_archive and import_ipc2581_archive #212

Merged
merged 10 commits into from
Jan 17, 2024

Conversation

ansys-pwalters
Copy link
Collaborator

Added polyline simplification to import_odb_archive and import_ipc2581_archive

Checklist:

  • [] Run unit tests and make sure they all pass
  • [] Check and fix style errors
    - pre-commit command line check
    - Problems tab in PyCharm
  • [] Bench test new/modified APIs by using and modifying the code in the example for the API method
  • [] Add new classes to rst files, located at: \doc\source\api
  • [] Generate documentation
  • [] Verify the HTML. It gets generated at: \doc\build\html.
    - Open index.html
    - Click on "API Reference" at the top.
    - Verify HTML for API changes.
  • [] Check that test code coverage is at least 80% when Sherlock is running and can be connected to using gRPC

Copy link

codecov bot commented Jan 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (4308ba1) 56.17% compared to head (fec9fdb) 56.17%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #212   +/-   ##
=======================================
  Coverage   56.17%   56.17%           
=======================================
  Files          20       20           
  Lines        3217     3217           
=======================================
  Hits         1807     1807           
  Misses       1410     1410           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@anskhanson anskhanson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the example sections with the new parameters. I think that is used in the documentation. Here is the import ipc method documentation for reference https://sherlock.docs.pyansys.com/version/stable/api/_autosummary/ansys.sherlock.core.project.Project.import_ipc2581_archive.html

@ansys-pwalters
Copy link
Collaborator Author

@anskhanson Updated examples.

@ansys-pwalters ansys-pwalters enabled auto-merge (squash) January 17, 2024 16:53
@ansys-pwalters ansys-pwalters merged commit ebc3cac into main Jan 17, 2024
25 of 26 checks passed
@ansys-pwalters ansys-pwalters deleted the polyline0111 branch January 17, 2024 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants