Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New listThermalMaps() API #200

Merged
merged 13 commits into from
Jan 25, 2024
Merged

New listThermalMaps() API #200

merged 13 commits into from
Jan 25, 2024

Conversation

ansnfernand
Copy link
Collaborator

Create an API to list the thermal map files and their types

Checklist:

  • Run unit tests and make sure they all pass
  • Check and fix style errors
    - pre-commit command line check
    - Problems tab in PyCharm
  • Bench test new/modified APIs by using and modifying the code in the example for the API method
    N/A Add new classes to rst files, located at: \doc\source\api
  • Generate documentation
  • Verify the HTML. It gets generated at: \doc\build\html.
    - Open index.html
    - Click on "API Reference" at the top.
    - Verify HTML for API changes.
  • Check that test code coverage is at least 80% when Sherlock is running and can be connected to using gRPC

Create an API to list the thermal map files and their types
@ansnfernand ansnfernand enabled auto-merge (squash) November 7, 2023 14:02
Copy link

codecov bot commented Nov 7, 2023

Codecov Report

Attention: 15 lines in your changes are missing coverage. Please review.

Comparison is base (ebc3cac) 56.17% compared to head (df6190d) 56.14%.

Files Patch % Lines
src/ansys/sherlock/core/project.py 39.13% 14 Missing ⚠️
src/ansys/sherlock/core/errors.py 88.88% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #200      +/-   ##
==========================================
- Coverage   56.17%   56.14%   -0.04%     
==========================================
  Files          20       20              
  Lines        3217     3249      +32     
==========================================
+ Hits         1807     1824      +17     
- Misses       1410     1425      +15     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

src/ansys/sherlock/core/project.py Outdated Show resolved Hide resolved
src/ansys/sherlock/core/project.py Outdated Show resolved Hide resolved
@ansnfernand ansnfernand disabled auto-merge November 16, 2023 15:11
@ansnfernand ansnfernand removed the request for review from ansys-pwalters January 24, 2024 19:18
@ansnfernand ansnfernand merged commit 4449001 into main Jan 25, 2024
25 of 28 checks passed
@ansnfernand ansnfernand deleted the listThermalMapsAPI branch January 25, 2024 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants