FIX: Remove unnecessary prints from embedding rpc #1090
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
dipinknair
commented
Feb 10, 2025
•
dipinknair
commented
- Improves how clients waiting till server is ready
- removes some unwanted prints
github-actions
bot
added
the
documentation
dipinknair
commented
Feb 10, 2025
| @@ -67,15 +66,6 @@ def _install_class(self, impl): | |||
| elif methodtype == MethodType.PROP: | |||
| self._install_property(method, methodname) | |||
|
|
|||
| def on_connect(self, conn): | |||
There was a problem hiding this comment.
@koubaa this is not necessary since we are printing the app when we start the server. This is what was causing multiple repeating prints
dipinknair
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1090 +/- ##
==========================================
- Coverage 87.12% 87.04% -0.08%
==========================================
Files 41 41
Lines 2835 2826 -9
==========================================
- Hits 2470 2460 -10
- Misses 365 366 +1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.