Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAINT - Update to Support Fluent 0.28 #305

Merged
merged 6 commits into from
Feb 11, 2025
Merged

MAINT - Update to Support Fluent 0.28 #305

merged 6 commits into from
Feb 11, 2025

Conversation

da1910
Copy link
Collaborator

@da1910 da1910 commented Feb 7, 2025

With 25.1 released we need to update fluent to support the latest version.

The API has changed, so the serializers had to change, while I'm here lets update to 3.12 and update MAPDL to the equiveltn 25.1 release

- Fix fluent import and API
- Update minimum python version
@github-actions github-actions bot added enhancement New features or code improvements dependencies Related with project dependencies maintenance Package and maintenance related testing Involves the development of new unit/functional tests labels Feb 7, 2025
Copy link

codecov bot commented Feb 7, 2025

Codecov Report

Attention: Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 84.83%. Comparing base (e2bcb98) to head (a43eacf).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #305      +/-   ##
==========================================
- Coverage   85.14%   84.83%   -0.32%     
==========================================
  Files          23       23              
  Lines        1003     1002       -1     
==========================================
- Hits          854      850       -4     
- Misses        149      152       +3     

@github-actions github-actions bot added the ci/cd Involves changes or updates to the build and test pipelines label Feb 7, 2025
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Feb 7, 2025
Copy link

@ludovicsteinbach ludovicsteinbach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look ok

@da1910 da1910 merged commit afff8b9 into main Feb 11, 2025
26 of 27 checks passed
@da1910 da1910 deleted the feat/fluent_0.28 branch February 11, 2025 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci/cd Involves changes or updates to the build and test pipelines dependencies Related with project dependencies documentation Improvements or additions to documentation enhancement New features or code improvements maintenance Package and maintenance related testing Involves the development of new unit/functional tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants