ci: improving testing

doc/changelog.d/3716.dependencies.md

@@ -0,0 +1 @@
+ci: improving testing

doc/changelog.d/3731.miscellaneous.md

@@ -0,0 +1 @@
+feat: adding opened attribute

pyproject.toml

@@ -136,6 +136,9 @@ markers = [
 ]
 testpaths = "tests"
 image_cache_dir = "tests/.image_cache"
+# Output logging records as they are emitted directly into the console
+# https://docs.pytest.org/en/stable/how-to/logging.html#live-logs
+log_cli = true 
 
 [tool.isort]
 profile = "black"

src/ansys/mapdl/core/mapdl_core.py

@@ -22,7 +22,7 @@
 
 """Module to control interaction with MAPDL through Python"""
 
-import atexit
+# import atexit
 from functools import wraps
 import glob
 import logging
@@ -264,7 +264,7 @@ def __init__(
         **start_parm,
     ):
         """Initialize connection with MAPDL."""
-        atexit.register(self.__del__)  # registering to exit properly
+        # atexit.register(self.__del__)  # registering to exit properly
         self._show_matplotlib_figures = True  # for testing
         self._query = None
         self._exited: bool = False

src/ansys/mapdl/core/xpl.py

@@ -124,6 +124,7 @@ def close(self):
         """
         response = self._mapdl.run("*XPL,CLOSE")
         self._check_ignored(response)
+        self._filename = None
         self._open = False
         return response
 
@@ -373,6 +374,8 @@ def save(self):
         """Save the current file, ignoring the marked records."""
         response = self._mapdl.run("*XPL,SAVE").strip()
         self._check_ignored(response)
+        self._open = False
+        self._filename = None
         return response
 
     def extract(self, recordname, sets="ALL", asarray=False):
@@ -550,8 +553,15 @@ def write(self, recordname, vecname):
     def __repr__(self):
         txt = "MAPDL File Explorer\n"
         if self._open:
-            txt += "\tOpen file:%s" % self._filename
+            txt += f"\tOpen file : {self._filename}"
             txt += "\n".join(self.where().splitlines()[1:])
         else:
             txt += "\tNo open file"
         return txt
+
+    @property
+    def opened(self):
+        if self._open:
+            return self._filename
+        else:
+            return None

tests/conftest.py

@@ -515,7 +515,7 @@ def path_tests(tmpdir):
 
 
 def clear(mapdl):
-    mapdl.mute = True
+    # mapdl.mute = True
     mapdl.finish()
     # *MUST* be NOSTART.  With START fails after 20 calls...
     # this has been fixed in later pymapdl and MAPDL releases
@@ -525,7 +525,7 @@ def clear(mapdl):
     mapdl.page("DEFA")
 
     mapdl.prep7()
-    mapdl.mute = False
+    # mapdl.mute = False
 
 
 @pytest.fixture(scope="function")

tests/test_xpl.py

@@ -47,6 +47,15 @@ def create_cube(self, mapdl):
 
         clear(mapdl)
 
+        # Delete files
+        self.full_file = mapdl.jobname + ".full"
+
+        if "full.file" in mapdl.list_files():
+            mapdl.slashdelete("full.file")
+
+        if mapdl.result_file in mapdl.list_files():
+            mapdl.slashdelete(mapdl.result_file)
+
         # set up the full file
         mapdl.block(0, 1, 0, 1, 0, 1)
         mapdl.et(1, 186)
@@ -59,20 +68,9 @@ def create_cube(self, mapdl):
         mapdl.esize(0.5)
         mapdl.vmesh("all")
 
-        # Delete files
-        self.full_file = mapdl.jobname + ".full"
-        if "full.file" in mapdl.list_files():
-            mapdl.slashdelete("full.file")
-
-        if mapdl.result_file in mapdl.list_files():
-            mapdl.slashdelete(mapdl.result_file)
-
-        if mapdl.result_file in mapdl.list_files():
-            mapdl.slashdelete(mapdl.result_file)
-
         # solve first 10 non-trivial modes
         mapdl.modal_analysis(nmode=10, freqb=1)
-        mapdl.save("cube_solve_xpl")
+        mapdl.save("cube_solve_xpl", slab="all")
 
     @pytest.fixture(scope="class")
     def cube_solve(self, mapdl):
@@ -88,10 +86,13 @@ def xpl(self, mapdl, cube_solve):
             self.create_cube(mapdl)
 
         xpl.open(self.full_file)
-        return xpl
 
-    @staticmethod
-    def test_close(xpl):
+        yield xpl
+
+        if xpl.opened:
+            xpl.close()
+
+    def test_close(self, xpl):
         xpl.close()
         with pytest.raises(MapdlCommandIgnoredError):
             xpl.list()
@@ -198,3 +199,10 @@ def test_extract(self, xpl):
 
         mat = xpl.extract("NSL")
         assert mat.shape == (243, 10)
+
+    def test_opened(self, xpl):
+        assert xpl.opened
+        xpl.close()
+        assert not xpl.opened
+        xpl.open(self.full_file)
+        assert xpl.opened