Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: updated required ansys-sphinx-theme version #497

Merged
merged 4 commits into from
Nov 25, 2024

Conversation

moe-ad
Copy link
Contributor

@moe-ad moe-ad commented Nov 21, 2024

Description

This PR fixes #490 and ansys-internal/pyansys-planning#96.
Examples in the stable version of pyhps documentation are not rendering properly. The cause of this behavior is the old ansys-sphinx-theme version that was in use when the stable version of the doc was deployed, and updating to the latest version fixes the issue. A v0.9.1 patch release is therefore recommended.

Checklist

  • I have tested these changes locally.
  • I have added necessary documentation or updated existing documentation.
  • I have linked the issue(s) addressed by this PR if any.

@moe-ad moe-ad requested a review from FedericoNegri November 21, 2024 10:16
@moe-ad moe-ad self-assigned this Nov 21, 2024
@github-actions github-actions bot added dependencies Related with project dependencies maintenance Package and maintenance related bug Something isn't working labels Nov 21, 2024
Copy link

codecov bot commented Nov 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.25%. Comparing base (f637726) to head (4e54705).
Report is 1 commits behind head on release/0.9.

Additional details and impacted files
@@               Coverage Diff               @@
##           release/0.9     #497      +/-   ##
===============================================
+ Coverage        93.21%   93.25%   +0.04%     
===============================================
  Files               64       64              
  Lines             2489     2489              
===============================================
+ Hits              2320     2321       +1     
+ Misses             169      168       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@FedericoNegri FedericoNegri merged commit fdb3b2f into release/0.9 Nov 25, 2024
21 checks passed
@FedericoNegri FedericoNegri deleted the fix/examples-rendering-style branch November 25, 2024 07:32
@FedericoNegri FedericoNegri linked an issue Nov 25, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working dependencies Related with project dependencies maintenance Package and maintenance related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve the style of the examples
2 participants