Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FEAT: Edb cfg equipotential #999

Merged
merged 6 commits into from
Jan 28, 2025
Merged

FEAT: Edb cfg equipotential #999

merged 6 commits into from
Jan 28, 2025

Conversation

hui-zhou-a
Copy link
Collaborator

@hui-zhou-a hui-zhou-a commented Jan 28, 2025

  • Move _em_proerties to Primitive class, since it is accessible for all primitives not only padstack.
  • EDB API has a bug in equipotential region. The workaround is to create a primitive and make it equipotential region
  • New feature in edb config. The user is able to define an equipotential region for sources with point terminals.
  • Deleted some redundant lines

@github-actions github-actions bot added documentation Improvements or additions to documentation testing Anything related to testing labels Jan 28, 2025
@codecov-commenter
Copy link

codecov-commenter commented Jan 28, 2025

Codecov Report

Attention: Patch coverage is 88.23529% with 8 lines in your changes missing coverage. Please review.

Project coverage is 82.67%. Comparing base (58ca21e) to head (a988085).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #999   +/-   ##
=======================================
  Coverage   82.66%   82.67%           
=======================================
  Files         160      160           
  Lines       21177    21213   +36     
=======================================
+ Hits        17507    17537   +30     
- Misses       3670     3676    +6     

@hui-zhou-a hui-zhou-a added bug Something isn't working enhancement New features or code improvements and removed testing Anything related to testing documentation Improvements or additions to documentation labels Jan 28, 2025
Copy link
Collaborator

@svandenb-dev svandenb-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@svandenb-dev svandenb-dev merged commit f9efc0f into main Jan 28, 2025
29 of 30 checks passed
@svandenb-dev svandenb-dev deleted the edb-cfg-equipotential branch January 28, 2025 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New features or code improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants