Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: Do not raise str while only classes or instances are allowed. #957

Merged
merged 3 commits into from
Jan 3, 2025

Conversation

MaxJPRey
Copy link
Collaborator

No description provided.

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 82.69%. Comparing base (0ee121c) to head (f87e738).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #957   +/-   ##
=======================================
  Coverage   82.69%   82.69%           
=======================================
  Files         160      160           
  Lines       21117    21117           
=======================================
  Hits        17462    17462           
  Misses       3655     3655           

Copy link
Collaborator

@hui-zhou-a hui-zhou-a left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hui-zhou-a hui-zhou-a merged commit 38ef3ae into main Jan 3, 2025
30 checks passed
@hui-zhou-a hui-zhou-a deleted the maint/code_patterns branch January 3, 2025 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants