Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: Primitive casting #1004

Merged
merged 1 commit into from
Jan 30, 2025
Merged

FIX: Primitive casting #1004

merged 1 commit into from
Jan 30, 2025

Conversation

maxcapodi78
Copy link
Collaborator

Sometimes Primitives contains empty objects (probably after boolean operations). This cause the casting to fail.

@codecov-commenter
Copy link

codecov-commenter commented Jan 30, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.67%. Comparing base (ec2b640) to head (5bcc20b).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1004   +/-   ##
=======================================
  Coverage   82.67%   82.67%           
=======================================
  Files         160      160           
  Lines       21213    21213           
=======================================
  Hits        17537    17537           
  Misses       3676     3676           

Copy link
Collaborator

@svandenb-dev svandenb-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@svandenb-dev svandenb-dev merged commit 10d90c0 into main Jan 30, 2025
30 checks passed
@svandenb-dev svandenb-dev deleted the fix_primitives_when_none branch January 30, 2025 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants