Improve data tree #1339
Merged
Improve data tree #1339
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1339 +/- ##
==========================================
- Coverage 87.60% 87.45% -0.16%
==========================================
Files 81 81
Lines 9262 9259 -3
==========================================
- Hits 8114 8097 -17
- Misses 1148 1162 +14 |
PProfizi
reviewed
Jan 8, 2024
| assert data_tree.get_as("string", str) == "hello" | ||
| assert data_tree.get_as("list_int", dpf.types.vec_int) == [1, 2] | ||
| assert data_tree.get_as("list_double", dpf.types.vec_double) == [1.5, 2.5] | ||
| assert data_tree.get_as("list_string", dpf.types.vec_string) == ["hello", "bye"] |
There was a problem hiding this comment.
@cbellot000 quick question: why is this not the default output type for a list of strings? Also could we have a description of the change in the PR?
There was a problem hiding this comment.
The data tree doesn't hold typed data, it only holds string, so we can only return strings by default
PProfizi
approved these changes
Jan 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.