Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prioritize the latest DPF server installed in the current Python environment #1268

Closed
wants to merge 3 commits into from

Conversation

PProfizi
Copy link
Contributor

@PProfizi PProfizi commented Nov 14, 2023

Closes #1265

Edit: one more use-case arose of the current behavior being misunderstood for a bug. Again, the user expected the DPF server he had just installed in his venv to be the one used by PyDPF.

NB:

  • the modifications on ansys/dpf/gate are here to showcase what modifications must be made on pygate
  • we could rename everything from find_ansys to find_dpf as this better describes what it does.

Edit: the changes to gate have been merged server-side

@PProfizi PProfizi self-assigned this Nov 14, 2023
@PProfizi PProfizi requested a review from a team as a code owner November 14, 2023 13:17
@PProfizi PProfizi added the enhancement New feature or request label Nov 14, 2023
@PProfizi PProfizi changed the title Prioritize the DPF server installed in the current Python environment Prioritize the latest DPF server installed in the current Python environment Nov 14, 2023
Copy link

codecov bot commented Nov 14, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (64b2a9b) 87.44% compared to head (be804b0) 86.26%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1268      +/-   ##
==========================================
- Coverage   87.44%   86.26%   -1.18%     
==========================================
  Files          81       81              
  Lines        9262     9255       -7     
==========================================
- Hits         8099     7984     -115     
- Misses       1163     1271     +108     

@PProfizi
Copy link
Contributor Author

Closing as merged in pygate

@PProfizi PProfizi closed this Dec 21, 2023
@PProfizi PProfizi deleted the feat/prioritize_dpf_server_in_venv branch November 28, 2024 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Prioritize ansys_dpf_server in current venv
1 participant