Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Adding RF Report Features (face color, separation, and rounds) #1732

Open
wants to merge 19 commits into
base: main
Choose a base branch
from
Open

feat: Adding RF Report Features (face color, separation, and rounds) #1732

wants to merge 19 commits into from
+420 −52

Conversation

jacobrkerstetter
Copy link
Contributor

@jacobrkerstetter jacobrkerstetter commented Feb 6, 2025 •
edited
Loading

Description

Adding various features needed for workflow 10. Includes Face RoundInfo, Face/Body ClosestSeparation, and Face Colors.

Issue linked

Checklist

  • I have tested my changes locally.
  • I have added necessary documentation or updated existing documentation.
  • I have followed the coding style guidelines of this project.
  • I have added appropriate unit tests.
  • I have reviewed my changes before submitting this pull request.
  • I have linked the issue or issues that are solved to the PR if any.
  • I have assigned this PR to myself.
  • I have added the minimum version decorator to any new backend method implemented.
  • I have made sure that the title of my PR follows Conventional commits style (e.g. feat: extrude circle to cylinder)

jkerstet added 6 commits January 31, 2025 11:30
- conversion of grpc point to pygeom point3d type
a0fa6ca 
- get round info + test
- get closest separation (body to body) + test
implemented and tested get_closest_separation for face
1c104a2
- added get face bounding box and test
a3dcaeb 
- wip design insert file with body names
added and tested bitwise and operator for bounding boxes
4197ac1
wip
c2492ef 
implemented face colors
working on coloring tessellations
- more plotting tests
fa93974 
- face get color efficiency fix
- body export_gltf for exporting single bodies
@jacobrkerstetter jacobrkerstetter self-assigned this Feb 6, 2025
@jacobrkerstetter jacobrkerstetter requested a review from a team as a code owner February 6, 2025 20:37
@github-actions github-actions bot added testing Anything related to tests enhancement New features or code improvements labels Feb 6, 2025
RobPasMue
RobPasMue requested changes Feb 7, 2025
View reviewed changes
src/ansys/geometry/core/connection/conversions.py Outdated Show resolved Hide resolved
src/ansys/geometry/core/designer/body.py Outdated Show resolved Hide resolved
src/ansys/geometry/core/designer/body.py Outdated Show resolved Hide resolved
src/ansys/geometry/core/designer/body.py Outdated Show resolved Hide resolved
src/ansys/geometry/core/designer/body.py Outdated Show resolved Hide resolved
src/ansys/geometry/core/designer/face.py Outdated Show resolved Hide resolved
src/ansys/geometry/core/designer/geometry_commands.py Outdated Show resolved Hide resolved
src/ansys/geometry/core/designer/geometry_commands.py Outdated Show resolved Hide resolved
src/ansys/geometry/core/math/bbox.py Outdated Show resolved Hide resolved
src/ansys/geometry/core/math/bbox.py Outdated Show resolved Hide resolved
jkerstet and others added 7 commits February 7, 2025 08:13
Merge branch 'main' of https://github.com/ansys/pyansys-geometry into…
c9b721a 
… feat/workflow_10_additions
- removed get_closest_separation from face and body
b14d29a 
- activated MeasurementTools for CoreService
- refactored intersecting bounding boxes to meet standards
- abstracted color conversion to hex to auxiliary method
- added tests for all features
@pre-commit-ci
chore: auto fixes from pre-commit hooks
df15c14
fixed docustring
1727dab
Merge branch 'feat/workflow_10_additions' of https://github.com/ansys…
ddf5463 
…/pyansys-geometry into feat/workflow_10_additions
edit to measurement tools for new rpc
9c8a97e
@jacobrkerstetter
Merge branch 'main' into feat/workflow_10_additions
ec56632
@RobPasMue
Copy link
Member

RobPasMue commented Feb 11, 2025 •
edited
Loading

@jacobrkerstetter - can we improve the title of the PR? I know it makes sense for you (us) since we know what workflow 10 stands for but let's assign it a more feature-oriented name if possible =)

@github-actions github-actions bot added the maintenance Package and maintenance related label Feb 11, 2025
@jacobrkerstetter jacobrkerstetter changed the title feat: workflow 10 additions feat: Adding RF Report Features (face color, separation, and rounds) Feb 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RobPasMue RobPasMue RobPasMue requested changes

@jonahrb jonahrb Awaiting requested review from jonahrb

@jrwest440 jrwest440 Awaiting requested review from jrwest440

Requested changes must be addressed to merge this pull request.

Assignees

@jacobrkerstetter jacobrkerstetter

Labels
enhancement New features or code improvements maintenance Package and maintenance related testing Anything related to tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jacobrkerstetter @RobPasMue @pyansys-ci-bot