-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: allow for debug mode execution #1577
Closed
Closed
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
26b976d
feat: allow for debug mode execution
RobPasMue eadcb92
chore: adding changelog file 1577.added.md [dependabot-skip]
pyansys-ci-bot 8aceaf3
Merge branch 'main' into feat/debug-mode-run-discovery-script
RobPasMue e4e3bdc
Merge branch 'main' into feat/debug-mode-run-discovery-script
RobPasMue 2192360
Merge branch 'main' into feat/debug-mode-run-discovery-script
RobPasMue File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
allow for debug mode execution |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -129,3 +129,19 @@ def test_dscript_simple_script(modeler: Modeler): | |
assert len(result) == 2 | ||
assert pattern_db.match(result["design_body"]) | ||
assert pattern_doc.match(result["design"]) | ||
|
||
|
||
# Discovery (.dscript) | ||
def test_dscript_simple_script_debug_mode(modeler: Modeler): | ||
# Skip on Linux | ||
skip_if_linux(modeler, test_dscript_simple_script.__name__, "run_discovery_script_file") | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Same here, if debug run script won't be available on DMS before it's retired, we'll need to skip that test for DMS |
||
|
||
result = modeler.run_discovery_script_file( | ||
DSCOSCRIPTS_FILES_DIR / "simple_script.dscript", enable_debug_features=True | ||
) | ||
assert len(result) == 2 | ||
pattern_db = re.compile(r"SpaceClaim\.Api\.[A-Za-z0-9]+\.DesignBody", re.IGNORECASE) | ||
pattern_doc = re.compile(r"SpaceClaim\.Api\.[A-Za-z0-9]+\.Document", re.IGNORECASE) | ||
assert len(result) == 2 | ||
assert pattern_db.match(result["design_body"]) | ||
assert pattern_doc.match(result["design"]) |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Depending on what Ken tells us about the debug mode, we might need to filter here if we run against DMS.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good!