Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUILD: Avoid new attrs release #5697

Merged
merged 1 commit into from
Jan 26, 2025
Merged

Conversation

SMoraisAnsys
Copy link
Collaborator

Description

The tool used to check license is not yet able to work with PEP 639, I just proposed a PR to fix that (raimon49/pip-licenses#226) but in the mean time we must avoid the latests versions of attrs.

Issue linked

Checklist

  • I have tested my changes locally.
  • I have added necessary documentation or updated existing documentation.
  • I have followed the coding style guidelines of this project.
  • I have added appropriate tests (unit, integration, system).
  • I have reviewed my changes before submitting this pull request.
  • I have linked the issue or issues that are solved by the PR if any.
  • I have agreed with the Contributor License Agreement (CLA).

@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@github-actions github-actions bot added the maintenance Package and maintenance related label Jan 26, 2025
@SMoraisAnsys
Copy link
Collaborator Author

@Samuelopez-ansys Please have a look to this PR as soon as possible to allow CICD to work correctly :)

Copy link

codecov bot commented Jan 26, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.24%. Comparing base (8c592a1) to head (c8d53c7).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5697   +/-   ##
=======================================
  Coverage   85.24%   85.24%           
=======================================
  Files         154      154           
  Lines       60767    60767           
=======================================
  Hits        51802    51802           
  Misses       8965     8965           

@SMoraisAnsys SMoraisAnsys merged commit dc03292 into main Jan 26, 2025
43 checks passed
@SMoraisAnsys SMoraisAnsys deleted the build/do-not-allow-latests-attrs branch January 26, 2025 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Package and maintenance related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant