Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

REFACTOR: General improvements #5674

Merged
merged 3 commits into from
Jan 21, 2025
Merged

Conversation

SMoraisAnsys
Copy link
Collaborator

@SMoraisAnsys SMoraisAnsys commented Jan 17, 2025

Description

General improvements which include:

  • removal of useless try: ... except: ...
  • removal of assert in non test code and raise of AEDTRuntimeError instead
  • refactor some part of the code to make it more readable (might be subjective :D)

Issue linked

Associated to #5504

Checklist

  • I have tested my changes locally.
  • I have added necessary documentation or updated existing documentation.
  • I have followed the coding style guidelines of this project.
  • I have added appropriate tests (unit, integration, system).
  • I have reviewed my changes before submitting this pull request.
  • I have linked the issue or issues that are solved by the PR if any.
  • I have agreed with the Contributor License Agreement (CLA).

@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

Copy link

codecov bot commented Jan 17, 2025

Codecov Report

Attention: Patch coverage is 77.77778% with 6 lines in your changes missing coverage. Please review.

Project coverage is 85.24%. Comparing base (de0df32) to head (58372ae).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5674   +/-   ##
=======================================
  Coverage   85.23%   85.24%           
=======================================
  Files         154      154           
  Lines       60764    60767    +3     
=======================================
+ Hits        51792    51800    +8     
+ Misses       8972     8967    -5     

@SMoraisAnsys SMoraisAnsys force-pushed the refactor/general-improvements branch from 3a80a9e to 58372ae Compare January 21, 2025 12:26
Copy link
Member

@Samuelopez-ansys Samuelopez-ansys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SMoraisAnsys SMoraisAnsys merged commit 8c592a1 into main Jan 21, 2025
42 of 43 checks passed
@SMoraisAnsys SMoraisAnsys deleted the refactor/general-improvements branch January 21, 2025 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants