Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

REFACTOR: New assign priority function #4717

Merged
merged 13 commits into from
May 27, 2024
Merged

REFACTOR: New assign priority function #4717

merged 13 commits into from
May 27, 2024

Conversation

lorenzovecchietti
Copy link
Contributor

@lorenzovecchietti lorenzovecchietti commented May 23, 2024 •
edited
Loading

Close #4645

@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@lorenzovecchietti lorenzovecchietti changed the title New assign priority function REFACTOR: New assign priority function May 23, 2024
@codecov-commenter
Copy link

codecov-commenter commented May 23, 2024 •
edited by codecov bot
Loading

Codecov Report

Attention: Patch coverage is 91.66667% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 80.41%. Comparing base (a67460f) to head (d15dbb8).

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #4717      +/-   ##
==========================================
- Coverage   80.41%   80.41%   -0.01%     
==========================================
  Files         121      121              
  Lines       55100    55136      +36     
==========================================
+ Hits        44308    44336      +28     
- Misses      10792    10800       +8

@lorenzovecchietti lorenzovecchietti marked this pull request as ready for review May 24, 2024 09:33
SMoraisAnsys
SMoraisAnsys reviewed May 27, 2024
View reviewed changes
Copy link
Collaborator

@SMoraisAnsys SMoraisAnsys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there might be a typo, feel free to resolve the conversation if I'm wrong.

pyaedt/modules/MeshIcepak.py Outdated Show resolved Hide resolved
pyaedt/modules/MeshIcepak.py Show resolved Hide resolved
SMoraisAnsys
SMoraisAnsys approved these changes May 27, 2024
View reviewed changes
Copy link
Collaborator

@SMoraisAnsys SMoraisAnsys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lorenzovecchietti lorenzovecchietti merged commit 3a3657e into main May 27, 2024
34 checks passed
@lorenzovecchietti lorenzovecchietti deleted the assign_priority branch May 27, 2024 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PipKat PipKat PipKat left review comments

@SMoraisAnsys SMoraisAnsys SMoraisAnsys approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug located in assign_priority
4 participants
@lorenzovecchietti @codecov-commenter @PipKat @SMoraisAnsys