DOCS: Revert changes to use webp #4716
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening a Pull Request. If you want to perform a review write a comment saying: @ansys-reviewer-bot review |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4716 +/- ##
==========================================
- Coverage 80.38% 80.38% -0.01%
==========================================
Files 122 122
Lines 55089 55095 +6
==========================================
+ Hits 44285 44286 +1
- Misses 10804 10809 +5 |
SMoraisAnsys
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test fixing documentation issue associated to #4655. Unfortunately WEBP image files can only be used to build HTML files and not the PDF file.
Indeed, WEBP image files are not working with latex (see jgm/pandoc#5267 (comment)) and to keep using them, we would have to use a converter. While it could be a valid solution I think that it would add to much things to handle (like a dedicated sphinx event hook) to look for WEBP extension and convert the associated files into JPEG + modifying the doc to not use WEBP file but JPEG...
This PR partially revert changes of #4655 to use previous JPEG / PNG files. It still keep the removed files that were part of the repo but not used in the documentation any more.